Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add MsgAddAuthorization to add or update and authorization and MsgRemoveAuthorization to remove a authorization #2305

Merged
merged 13 commits into from
Jun 4, 2024

Conversation

kingpinXD
Copy link
Contributor

Description

This pr adds the following messages, which can be used to update the authorization list

  • MsgAddAuthorization : Add or update an authorization
  • MsgRemoveAuthorization: Remove existing authorization

Closes: #2288

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.44%. Comparing base (c93d1c6) to head (e441631).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2305      +/-   ##
===========================================
+ Coverage    69.27%   69.44%   +0.16%     
===========================================
  Files          276      281       +5     
  Lines        16563    16654      +91     
===========================================
+ Hits         11474    11565      +91     
  Misses        4604     4604              
  Partials       485      485              
Files Coverage Δ
x/authority/keeper/msg_server_add_authorization.go 100.00% <100.00%> (ø)
...uthority/keeper/msg_server_remove_authorization.go 100.00% <100.00%> (ø)
x/authority/types/authorizations.go 100.00% <100.00%> (ø)
x/authority/types/message_add_authorization.go 100.00% <100.00%> (ø)
x/authority/types/message_remove_authorization.go 100.00% <100.00%> (ø)
x/authority/types/policies.go 100.00% <100.00%> (ø)
x/authority/types/policy_type.go 100.00% <100.00%> (ø)

@kingpinXD kingpinXD marked this pull request as ready for review June 3, 2024 16:49
changelog.md Outdated Show resolved Hide resolved
x/authority/client/cli/tx_add_authorization.go Outdated Show resolved Hide resolved
x/authority/client/cli/tx_add_authorizations_test.go Outdated Show resolved Hide resolved
@kingpinXD kingpinXD changed the title feat: authorization list messages feat: add MsgAddAuthorization to add or update and authorization and MsgRemoveAuthorization to remove a authorization Jun 4, 2024
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, reporting some typos

x/authority/client/cli/tx.go Outdated Show resolved Hide resolved
x/authority/keeper/msg_server_add_authorization_test.go Outdated Show resolved Hide resolved
@kingpinXD kingpinXD requested a review from lumtis June 4, 2024 15:08
@kingpinXD kingpinXD merged commit 26b4f69 into develop Jun 4, 2024
19 checks passed
@kingpinXD kingpinXD deleted the authorization-list-messages branch June 4, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Messages to update authorization list
3 participants