-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add MsgAddAuthorization to add or update and authorization and MsgRemoveAuthorization to remove a authorization #2305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2305 +/- ##
===========================================
+ Coverage 69.27% 69.44% +0.16%
===========================================
Files 276 281 +5
Lines 16563 16654 +91
===========================================
+ Hits 11474 11565 +91
Misses 4604 4604
Partials 485 485
|
kingpinXD
commented
Jun 3, 2024
kingpinXD
commented
Jun 3, 2024
kingpinXD
requested review from
brewmaster012,
lumtis,
ws4charlie and
skosito
as code owners
June 3, 2024 16:49
10 tasks
lumtis
reviewed
Jun 4, 2024
skosito
reviewed
Jun 4, 2024
skosito
approved these changes
Jun 4, 2024
kingpinXD
changed the title
feat: authorization list messages
feat: add MsgAddAuthorization to add or update and authorization and MsgRemoveAuthorization to remove a authorization
Jun 4, 2024
lumtis
reviewed
Jun 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, reporting some typos
lumtis
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr adds the following messages, which can be used to update the authorization list
MsgAddAuthorization
: Add or update an authorizationMsgRemoveAuthorization
: Remove existing authorizationCloses: #2288
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: