Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: allow running Bitcoin tests on live networks (tentative) #2303

Merged
merged 11 commits into from
Jun 6, 2024
Merged

test: allow running Bitcoin tests on live networks (tentative) #2303

merged 11 commits into from
Jun 6, 2024

Conversation

lumtis
Copy link
Member

@lumtis lumtis commented Jun 3, 2024 •
edited
Loading

Description

  • Some code simplification
  • Prevent calling generate blocks if this is a live Bitcoin network
  • Remove the min amount check in utxos listing, local tests continues to past and this is necessary to support live network tests

Closes: #2298

@lumtis lumtis added the no-changelog Skip changelog CI check label Jun 3, 2024
@lumtis lumtis marked this pull request as ready for review June 5, 2024 07:15
@lumtis
Copy link
Member Author

lumtis commented Jun 5, 2024

@zeta-chain/protocol-engineering opening it for reviews

An issue in infrastructure prevents for completely testing if Bitcoin deposits work, we can test it once on develop. In any case, this PR does some fixes for the Bitcoin zetae2e package

skosito
skosito approved these changes Jun 5, 2024
View reviewed changes
e2e/e2etests/helper_bitcoin.go Outdated Show resolved Hide resolved
e2e/runner/bitcoin.go Show resolved Hide resolved
kingpinXD
kingpinXD reviewed Jun 5, 2024
View reviewed changes
e2e/runner/bitcoin.go Outdated Show resolved Hide resolved
@lumtis lumtis merged commit aec6ac2 into develop Jun 6, 2024
19 checks passed
@lumtis lumtis deleted the e2e/bitcoin-live-network branch June 6, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ws4charlie ws4charlie ws4charlie left review comments

@kingpinXD kingpinXD kingpinXD approved these changes

@skosito skosito skosito approved these changes

@brewmaster012 brewmaster012 Awaiting requested review from brewmaster012

Assignees
No one assigned
Labels
no-changelog Skip changelog CI check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to run Bitcoin E2E tests on live networks
4 participants
@lumtis @skosito @kingpinXD @ws4charlie