-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(e2e
): add a test to deploy contracts
#2299
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just in PR description, contract name and success message seems to mention testdapp_evm
in command and testdapp_zevm
in message:
zetae2e run deploy:testdapp_evm --config bsc_config.yml
e2e | starting tests
e2e | ⚙️ setting up TSS address
e2e | ⏳running - deploy a contract
e2e | testdapp_zevm deployed at 0x0eEcd709B767bd54CF5Ec5266672dE96F12Ad7D3
i think its ok to be part of run
command, but probably would be cleaner to have separate deploy command like zetae2e deploy
, i think some commands like balances
are already run in CI?
Copypaste mistake
Can be change if everyone think this makes sense. For the codebase simplicity, this also makes sense to me to use |
ah ok i didnt think about that, leaving it in |
Description
Add a entry in
zetae2e
allowing to deploy smart contracts used in some tests in the E2E tests (right now test_dapp on zevm and evm)Decided to add it as a "test" with the
run
command, so we can use it without any changes in our current CI.Usage:
Example:
Closes: #2227