Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move testdata from pkg to testutil #2296

Merged
merged 6 commits into from
Jun 4, 2024

Conversation

jasonmokk
Copy link
Contributor

@jasonmokk jasonmokk commented May 31, 2024

Description

This PR moves the testdata package from pkg into testutil since it is a test-related package.

Closes: #2292

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@jasonmokk jasonmokk marked this pull request as ready for review May 31, 2024 03:56
@lumtis lumtis changed the title chore: move testdata from pkg to testutil refactor: move testdata from pkg to testutil May 31, 2024
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the contribution!

Note @jasonmokk : would be good to ask on the issue first to be assigned to it. We generally assign issue for interested contributors, this is to ensure people are not working simultaneously on the same thing

@jasonmokk
Copy link
Contributor Author

jasonmokk commented May 31, 2024

LGTM Thanks for the contribution!

Note @jasonmokk : would be good to ask on the issue first to be assigned to it. We generally assign issue for interested contributors, this is to ensure people are not working simultaneously on the same thing

Got it, my apologies. Next time I'll make sure to comment on the issue/get assigned first before working on it.

Copy link
Contributor

@skosito skosito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, @lumtis should we approve and run all workflows before merging?

Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasonmokk seems like there are some tests with the location not updated: https://github.com/zeta-chain/node/actions/runs/9347664708/job/25725129231?pr=2296

@jasonmokk
Copy link
Contributor Author

jasonmokk commented Jun 4, 2024

@jasonmokk seems like there are some tests with the location not updated: zeta-chain/node/actions/runs/9347664708/job/25725129231?pr=2296

Thanks for the feedback, I've corrected the package location in the failing tests.

Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@lumtis lumtis merged commit 6c8e5a6 into zeta-chain:develop Jun 4, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move testdata from pkg to testutil
3 participants