-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move testdata
from pkg
to testutil
#2296
Conversation
testdata
from pkg
to testutil
testdata
from pkg
to testutil
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the contribution!
Note @jasonmokk : would be good to ask on the issue first to be assigned to it. We generally assign issue for interested contributors, this is to ensure people are not working simultaneously on the same thing
Got it, my apologies. Next time I'll make sure to comment on the issue/get assigned first before working on it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, @lumtis should we approve and run all workflows before merging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasonmokk seems like there are some tests with the location not updated: https://github.com/zeta-chain/node/actions/runs/9347664708/job/25725129231?pr=2296
Thanks for the feedback, I've corrected the package location in the failing tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Description
This PR moves the
testdata
package frompkg
intotestutil
since it is a test-related package.Closes: #2292
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: