Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fixing the docker build pipeline for release so we can cut docker… #2295

Merged
merged 3 commits into from
May 30, 2024
Merged

ci: fixing the docker build pipeline for release so we can cut docker… #2295

merged 3 commits into from
May 30, 2024

Conversation

gzukel
Copy link
Contributor

@gzukel gzukel commented May 30, 2024

Description

ci: fixing the docker build pipeline for release so we can cut docker images

Closes: Adhoc

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • CI Fix

How Has This Been Tested?

This is already in develop and has been tested. Merging to build v17 docker images.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@gzukel gzukel requested a review from a team as a code owner May 30, 2024 21:02
@github-actions github-actions bot added the ci Changes to CI pipeline or github actions label May 30, 2024
@gzukel gzukel merged commit 5a7df71 into release/v17 May 30, 2024
11 checks passed
@gzukel gzukel deleted the fix-docker-pipeline-in-v17 branch May 30, 2024 21:52
gartnera pushed a commit that referenced this pull request Jun 20, 2024
@gzukel @gartnera
ci: fixing the docker build pipeline for release so we can cut docker… (
6f96c28 
#2295)

* ci: fixing the docker build pipeline for release so we can cut docker images

* updated

* repushing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlieMc0 CharlieMc0 CharlieMc0 approved these changes

@skosito skosito skosito approved these changes

@brewmaster012 brewmaster012 Awaiting requested review from brewmaster012 brewmaster012 is a code owner

@kingpinXD kingpinXD Awaiting requested review from kingpinXD kingpinXD is a code owner

@lumtis lumtis Awaiting requested review from lumtis lumtis is a code owner

@ws4charlie ws4charlie Awaiting requested review from ws4charlie ws4charlie is a code owner

Assignees
No one assigned
Labels
ci Changes to CI pipeline or github actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gzukel @skosito @CharlieMc0