Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement MsgUpdateChainInfo #2287

Merged
merged 24 commits into from
May 30, 2024
Merged

Conversation

lumtis
Copy link
Member

@lumtis lumtis commented May 29, 2024

Description

Closes: #2271

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.14%. Comparing base (8eadf56) to head (14d06c3).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2287      +/-   ##
===========================================
+ Coverage    69.07%   69.14%   +0.06%     
===========================================
  Files          269      272       +3     
  Lines        16436    16472      +36     
===========================================
+ Hits         11353    11389      +36     
  Misses        4599     4599              
  Partials       484      484              
Files Coverage Δ
x/authority/keeper/grpc_query_chain_info.go 100.00% <100.00%> (ø)
x/authority/keeper/msg_server_update_chain_info.go 100.00% <100.00%> (ø)
x/authority/keeper/msg_server_update_policies.go 100.00% <100.00%> (ø)
x/authority/types/message_update_chain_info.go 100.00% <100.00%> (ø)
x/authority/types/message_update_policies.go 100.00% <100.00%> (ø)

@lumtis lumtis marked this pull request as ready for review May 29, 2024 15:05
Copy link
Contributor

@kingpinXD kingpinXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , minor comments.
Also , I am guessing we would just update the chain info via the message not need a migration script for this ?

x/authority/keeper/msg_server_update_chain_info.go Outdated Show resolved Hide resolved
x/authority/keeper/msg_server_update_chain_info.go Outdated Show resolved Hide resolved
x/authority/types/message_update_chain_info.go Outdated Show resolved Hide resolved
x/authority/types/message_update_chain_info.go Outdated Show resolved Hide resolved
@lumtis
Copy link
Member Author

lumtis commented May 30, 2024

LGTM , minor comments. Also , I am guessing we would just update the chain info via the message not need a migration script for this ?

We will continue using the hardcoded data, this one allow to add dynamically to avoid doing an upgrade to support a new chain. The structure will be empty at first

@lumtis lumtis merged commit 42458ae into develop May 30, 2024
19 checks passed
@lumtis lumtis deleted the feat/msg-upgrade-chain-info branch May 30, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement MsgUpdateChainInfo
3 participants