-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement MsgUpdateChainInfo
#2287
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2287 +/- ##
===========================================
+ Coverage 69.07% 69.14% +0.06%
===========================================
Files 269 272 +3
Lines 16436 16472 +36
===========================================
+ Hits 11353 11389 +36
Misses 4599 4599
Partials 484 484
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM , minor comments.
Also , I am guessing we would just update the chain info via the message not need a migration script for this ?
We will continue using the hardcoded data, this one allow to add dynamically to avoid doing an upgrade to support a new chain. The structure will be empty at first |
Co-authored-by: skosito <[email protected]>
Co-authored-by: skosito <[email protected]>
Description
Closes: #2271