Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove quotes from e2e args #2284

Merged
merged 1 commit into from
May 29, 2024
Merged

fix: remove quotes from e2e args #2284

merged 1 commit into from
May 29, 2024

Conversation

gartnera
Copy link
Member

Description

#2264 broke the performance tests:

unknown command "local --test-performance" for "zetae2e"

This is because of the double quotes, forcing the local --test performance args be passed as os.Args[1] rather than os.Args[1:3]

@gartnera gartnera added the no-changelog Skip changelog CI check label May 28, 2024
@lumtis lumtis merged commit 89ca461 into develop May 29, 2024
21 of 22 checks passed
@lumtis lumtis deleted the fix-performance-tests branch May 29, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Skip changelog CI check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants