fix: don't skip unsupported chain param and let it update the IsSupported flag in context
#2233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ws4charlie
requested review from
brewmaster012,
kingpinXD,
lumtis and
skosito
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2233 +/- ##
========================================
Coverage 68.06% 68.06%
========================================
Files 259 259
Lines 16017 16014 -3
========================================
- Hits 10902 10900 -2
+ Misses 4657 4653 -4
- Partials 458 461 +3
|
lumtis
reviewed
May 22, 2024
Yeah. It is used in below places by observer to pause |
…-disable-chain-by-IsSupported-flag
skosito
approved these changes
May 22, 2024
kingpinXD
approved these changes
May 23, 2024
lumtis
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The BSC Testnet was already disabled by setting
IsSupported = falsein chain parameter, but the zetaclient continues printing logs ofobserveInTX: lasstScanned heights for chain 97 ZetaSent 40544345 ERC20Deposited 40544345 TssRecvd 40544345.This means zetaclients were still observing BSC Testnet. After checking logs in Datadog, I noticed below log print is the place which prevents the
IsSupportedflag to be updated in the zetaclient's context, and the observation of outbound/inbound were not paused properly.Closes:
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: