Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updates for developnet #2229

Merged
merged 4 commits into from
May 21, 2024
Merged

chore: updates for developnet #2229

merged 4 commits into from
May 21, 2024

Conversation

gartnera
Copy link
Member

@gartnera gartnera commented May 21, 2024

Description

Relates to DEVOP-642

@gartnera gartnera added the no-changelog Skip changelog CI check label May 21, 2024
@github-actions github-actions bot added the ci Changes to CI pipeline or github actions label May 21, 2024
@gartnera gartnera marked this pull request as ready for review May 21, 2024 17:01
Copy link
Contributor

@CryptoFewka CryptoFewka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'd like to switch off of 20.04 in favor of something more recent, but if it's blocking something we can use 20.04 for the time being.

Copy link

gitguardian bot commented May 21, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11033145 Triggered Generic High Entropy Secret 12edde8 cmd/zetae2e/local/accounts.go View secret
11033146 Triggered Generic High Entropy Secret 12edde8 cmd/zetae2e/local/accounts.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@gartnera gartnera merged commit 6369109 into develop May 21, 2024
20 of 21 checks passed
@gartnera gartnera deleted the upgrade-orchestrator-tweaks branch May 21, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Changes to CI pipeline or github actions no-changelog Skip changelog CI check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants