Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve Go formatting with imports standardization and max line length to 120 #2226

Merged
merged 10 commits into from
May 22, 2024

Conversation

lumtis
Copy link
Member

@lumtis lumtis commented May 21, 2024

Description

The PR reimplement what was here:
#2211
#2213

I'm closing the former PRs as I had some issues with the conflicts. All info in the PR above

Copy link

!!!WARNING!!!
nosec detected in the following files: cmd/zetacore_utils/main.go, e2e/runner/accounting.go, rpc/backend/chain_info.go, rpc/backend/tracing.go, rpc/backend/tx_info.go, x/crosschain/keeper/cctx.go, x/crosschain/keeper/cctx_utils.go, x/crosschain/keeper/msg_server_vote_outbound_tx.go, x/fungible/keeper/msg_server_deploy_fungible_coin_zrc20.go, x/observer/abci.go, zetaclient/chains/bitcoin/fee_test.go, zetaclient/chains/bitcoin/observer/inbound.go, zetaclient/chains/bitcoin/observer/inbound_test.go, zetaclient/chains/bitcoin/observer/outbound.go, zetaclient/chains/evm/observer/inbound.go, zetaclient/chains/evm/signer/signer.go, zetaclient/tss/tss_signer.go

Be very careful about using #nosec in code. It can be a quick way to suppress security warnings and move forward with development, it should be employed with caution. Suppressing warnings with #nosec can hide potentially serious vulnerabilities. Only use #nosec when you're absolutely certain that the security issue is either a false positive or has been mitigated in another way.

Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203
Broad #nosec annotations should be avoided, as they can hide other vulnerabilities. The CI will block you from merging this PR until you remove #nosec annotations that do not target specific rules.

Pay extra attention to the way #nosec is being used in the files listed above.

@github-actions github-actions bot added the nosec label May 21, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 58.54430% with 131 lines in your changes are missing coverage. Please review.

Project coverage is 68.08%. Comparing base (6369109) to head (591870f).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2226      +/-   ##
===========================================
- Coverage    68.20%   68.08%   -0.12%     
===========================================
  Files          259      259              
  Lines        14960    16032    +1072     
===========================================
+ Hits         10203    10915     +712     
- Misses        4298     4658     +360     
  Partials       459      459              
Files Coverage Δ
app/custom_proposal_handler.go 0.00% <ø> (ø)
app/encoding.go 0.00% <ø> (ø)
app/init_genesis.go 0.00% <ø> (ø)
app/prefix.go 0.00% <ø> (ø)
pkg/crypto/pubkey.go 52.74% <ø> (ø)
pkg/crypto/tss.go 82.60% <100.00%> (ø)
pkg/proofs/headers.go 71.76% <ø> (ø)
pkg/proofs/proof.go 76.47% <ø> (ø)
x/authority/genesis.go 100.00% <ø> (ø)
x/authority/keeper/grpc_query_policies.go 100.00% <100.00%> (ø)
... and 34 more

... and 162 files with indirect coverage changes

Copy link

gitguardian bot commented May 21, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11033145 Triggered Generic High Entropy Secret 5a581a5 cmd/zetae2e/local/accounts.go View secret
11033146 Triggered Generic High Entropy Secret 5a581a5 cmd/zetae2e/local/accounts.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@lumtis lumtis merged commit 9df63f8 into develop May 22, 2024
19 of 21 checks passed
@lumtis lumtis deleted the import-fmt-2 branch May 22, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants