Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2e): set governance parameters for cosmos sdk v0.47+ #2198

Merged
merged 3 commits into from
May 17, 2024

Conversation

gartnera
Copy link
Member

Description

Set governance parameters in new params module for sdk v0.47+. These parameters will normally be migrated but is needed for localnet genesis.

Reference: https://github.com/cosmos/cosmos-sdk/blob/e03476679912736a615f9ed78dfb86f90c3be6bd/x/gov/proto/cosmos/gov/v1/genesis.proto#L31

Also a small change to allow interactively running the upgrade-orchestrator.sh directly on zetacore0 for testing.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

@gartnera gartnera added the no-changelog Skip changelog CI check label May 16, 2024
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gartnera gartnera merged commit e57eca1 into develop May 17, 2024
21 checks passed
@gartnera gartnera deleted the fix-v47-upgrade-localnet branch May 17, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Skip changelog CI check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants