fix(e2e): upgrade tests #2190
Merged
fix(e2e): upgrade tests #2190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gartnera
force-pushed
the
fix-upgrade-tests
branch
from
4f227d6 to
25c0a4c
Compare
gartnera
requested review from
brewmaster012,
kingpinXD,
lumtis,
ws4charlie and
skosito
as code owners
skosito
approved these changes
May 15, 2024
lumtis
added a commit
that referenced
this pull request
May 16, 2024
* fix(e2e): correct upgrade-host hostname * fix light upgrade * remove pointless tr * add version change assertion * formatting * fix voting * improve upgrade height check * fix upgrade name * refactor sleep logic --------- Co-authored-by: Lucas Bertrand <[email protected]>
lumtis
added a commit
that referenced
this pull request
May 17, 2024
…tests structure (#2181) * add some spacing * some clean up * add more assertions to zevm mp * changelog * reorganize e2e tests name * create file per test * fix error * some var name fix in zevm mp tests * add a no revert test dapp contract * add zevm mp revert fail test * fix zevm revert fail * evm to zevm revert fail * remove redundant types * change changelogs * Update changelog.md Co-authored-by: skosito <[email protected]> * ci: fix docker release pipeline tag issue. (#2189) * updated the docker build to utilize the github event release title and removed the mac build because the arm build covers that. * updated change log * ci: fixed the conditional for non release runs of the docker build (#2191) * ci: fixed the conditional for non release runs of the docker build * ci: Automate GitHub Release Status Update Based on ZetaChain Governance Proposals (#2192) * adding pipeline to automatically update the release status when a release has gone live i.e. the upgrade height is met and the network is processing blocks again. The script will then update the github release from pre-release to release as long as the release name matches the release title from the governance proposal * updated links to new all that node links * fix(e2e): upgrade tests (#2190) * fix(e2e): correct upgrade-host hostname * fix light upgrade * remove pointless tr * add version change assertion * formatting * fix voting * improve upgrade height check * fix upgrade name * refactor sleep logic --------- Co-authored-by: Lucas Bertrand <[email protected]> * add note for file per test --------- Co-authored-by: skosito <[email protected]> Co-authored-by: Grant Zukel <[email protected]> Co-authored-by: Alex Gartner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade tests were broken by #2158. I responded to some review comments without fully retesting the changes.
Fix the issues and add an assertion to
start-zetae2e.shthat the version actually changes between upgradesHow Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.