Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ibc and ibc-transfer modules #2145

Merged
merged 7 commits into from
May 10, 2024
Merged

Conversation

lumtis
Copy link
Member

@lumtis lumtis commented May 9, 2024

Description

Closes: #1510

Copy link

github-actions bot commented May 9, 2024

!!!WARNING!!!
nosec detected in the following files: docs/cli/zetacored/zetacored_tx_ibc-transfer_transfer.md

Be very careful about using #nosec in code. It can be a quick way to suppress security warnings and move forward with development, it should be employed with caution. Suppressing warnings with #nosec can hide potentially serious vulnerabilities. Only use #nosec when you're absolutely certain that the security issue is either a false positive or has been mitigated in another way.

Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203
Broad #nosec annotations should be avoided, as they can hide other vulnerabilities. The CI will block you from merging this PR until you remove #nosec annotations that do not target specific rules.

Pay extra attention to the way #nosec is being used in the files listed above.

@github-actions github-actions bot added the nosec label May 9, 2024
@lumtis lumtis marked this pull request as ready for review May 9, 2024 15:51
Copy link
Contributor

@kingpinXD kingpinXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm , do we need a migration script ?
If so would that be in a separate pr ?

@lumtis
Copy link
Member Author

lumtis commented May 9, 2024

lgtm , do we need a migration script ? If so would that be in a separate pr ?

Yes, will need but need adding IBC chain testing in E2E tests for this, which would be in a later PR

app/app.go Show resolved Hide resolved
@lumtis
Copy link
Member Author

lumtis commented May 10, 2024

Seems there is some issues with the upgrade test

@lumtis lumtis merged commit 7458093 into develop May 10, 2024
31 of 33 checks passed
@lumtis lumtis deleted the feat/add-ibc-transfer branch May 10, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add IBC support by importing the IBC transfer module
3 participants