Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(zetacored): use json upgrade proposal to workaround legacy proposal panic #2122

Merged
merged 1 commit into from
May 7, 2024
Merged

fix(zetacored): use json upgrade proposal to workaround legacy proposal panic #2122

merged 1 commit into from
May 7, 2024

Conversation

gartnera
Copy link
Member

@gartnera gartnera commented May 6, 2024 •
edited
Loading

Description

Use non-legacy software upgrade proposals via json to workaround panic

Closes: #2121

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

@gartnera gartnera marked this pull request as ready for review May 6, 2024 21:00
lumtis
lumtis approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

skosito
skosito approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@skosito skosito left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just 2 minor comments, please check before merge if they make sense

contrib/localnet/scripts/start-zetacored.sh Outdated Show resolved Hide resolved
contrib/localnet/scripts/start-zetacored.sh Outdated Show resolved Hide resolved
@gartnera gartnera force-pushed the fix-v047-upgrade branch from e6a3efa to a540838 Compare May 7, 2024 15:48
@gartnera gartnera added the no-changelog Skip changelog CI check label May 7, 2024
@kingpinXD kingpinXD mentioned this pull request May 7, 2024
Closed
10 tasks
@gartnera gartnera merged commit b460556 into develop May 7, 2024
21 of 22 checks passed
@gartnera gartnera deleted the fix-v047-upgrade branch May 7, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingpinXD kingpinXD kingpinXD approved these changes

@skosito skosito skosito approved these changes

@lumtis lumtis lumtis approved these changes

@brewmaster012 brewmaster012 Awaiting requested review from brewmaster012

@ws4charlie ws4charlie Awaiting requested review from ws4charlie

Assignees
No one assigned
Labels
no-changelog Skip changelog CI check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Software upgrades after cosmos sdk v0.47 upgrade are not working
4 participants
@gartnera @lumtis @skosito @kingpinXD