-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: consolidate inbound
and outbound
naming
#2118
Conversation
!!!WARNING!!! Be very careful about using Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203 Pay extra attention to the way |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2118 +/- ##
===========================================
- Coverage 68.25% 68.07% -0.19%
===========================================
Files 259 259
Lines 14918 14982 +64
===========================================
+ Hits 10183 10199 +16
- Misses 4273 4321 +48
Partials 462 462
|
Co-authored-by: Charlie Chen <[email protected]>
Co-authored-by: Charlie Chen <[email protected]>
Co-authored-by: Charlie Chen <[email protected]>
Co-authored-by: Charlie Chen <[email protected]>
Co-authored-by: Charlie Chen <[email protected]>
Co-authored-by: Charlie Chen <[email protected]>
Co-authored-by: Charlie Chen <[email protected]>
Co-authored-by: Charlie Chen <[email protected]>
Co-authored-by: Charlie Chen <[email protected]>
Co-authored-by: Charlie Chen <[email protected]>
Co-authored-by: Charlie Chen <[email protected]>
Co-authored-by: Charlie Chen <[email protected]>
Co-authored-by: Charlie Chen <[email protected]>
Co-authored-by: Charlie Chen <[email protected]>
Co-authored-by: Charlie Chen <[email protected]>
Co-authored-by: Charlie Chen <[email protected]>
Description
Use
inbound
naming to refers to cctx coming to ZetaChain andoutbound
for cctx to external chain.inTx
,receive
,inboundTx
->inbound
outTx
,send
,outboundTx
->outbound
Do also some naming simplification for some messages and query
VoteOnObserverInboundTx
->VoteInbound
VoteOnObserverOutboundTx
->VoteOutbound
AddToOutTxTracker
->AddOutboundTracker
AddToInTxTracker
->AddInboundTracker
RemoveFromOutTxTracker
->RemoveOutboundTracker
Move the breaking changes note to a specific file: https://github.com/zeta-chain/node/blob/refactor/rename-outbound-inbound/docs/releases/v17_breaking_changes.md#intx-and-outtx-renaming
The PR also introduces observer migration guide for v17: https://github.com/zeta-chain/node/blob/refactor/rename-outbound-inbound/docs/releases/v17_observer_migration.md
Successful upgrade test: https://github.com/zeta-chain/node/actions/runs/9112437066
Closes: #2011 #1797 #1082