refactor: authorizations table #2114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2114 +/- ##
===========================================
+ Coverage 72.34% 72.40% +0.05%
===========================================
Files 250 257 +7
Lines 14046 14214 +168
===========================================
+ Hits 10162 10291 +129
- Misses 3423 3459 +36
- Partials 461 464 +3
|
kingpinXD
changed the title
kingpinXD
requested review from
brewmaster012,
lumtis,
ws4charlie and
skosito
as code owners
lumtis
requested changes
May 10, 2024
Co-authored-by: Lucas Bertrand <[email protected]>
skosito
reviewed
May 13, 2024
lumtis
reviewed
May 14, 2024
| return false | ||
| } | ||
|
|
||
| var OperationalPolicyMessageList = []string{ |
There was a problem hiding this comment.
I'm thinking about defining a type PolicyTable containing a list [url,policy] tuples with crud methods, so it can be easily update, even if we add a new policy type and can be used once we persist the table in the state
|
|
||
| var OperationalPolicyMessageList = []string{ | ||
| // Crosschain admin messages | ||
| sdk.MsgTypeURL(&crosschaintypes.MsgRefundAbortedCCTX{}), |
There was a problem hiding this comment.
Can be made less verbose defining an alias
msgURL := sdk.MsgTypeURL
| "github.com/zeta-chain/zetacore/pkg/authorizations" | ||
| authoritytypes "github.com/zeta-chain/zetacore/x/authority/types" | ||
| ) | ||
|
|
There was a problem hiding this comment.
We can add assertion with all messages in the tests
| @@ -0,0 +1,59 @@ | |||
| package types | |||
There was a problem hiding this comment.
The test for this file use the pause message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MsgUpdateZRC20intoMsgPauseZRC20andMsgUnPauseZRC20MsgUpdateCrosschainFlagsintoMsgEnableCCTXFlagsMsgDisableCCTXFlagsandMsgUpdateGasPriceIncreaseFlagsMsgPauseZRC20 : PolicyType_groupEmergencyMsgUnPauseZRC20 PolicyType_groupOperationalMsgUpdateGasPriceIncreaseFlags : PolicyType_groupOperationalMsgEnableCCTXFlags : PolicyType_groupOperationalMsgDisableCCTXFlags : PolicyType_groupEmergencyCloses:#2107
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: