test: fix and unit tests for query pending cctx within rate limit #2060
Conversation
…t-withdraw-rate-limit
ws4charlie
requested review from
brewmaster012,
kingpinXD,
lumtis and
skosito
as code owners
|
!!!WARNING!!! Be very careful about using Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203 Pay extra attention to the way |
ws4charlie
changed the title
Co-authored-by: Lucas Bertrand <[email protected]>
There was a problem hiding this comment.
Tests look much more visual now!
I think this is fine for the test cases we currently have but I would suggest for future ones, using Zeta for CCTX as you can directly represent the amount of the CCTX.
The conversion logic is already tested in other tests.
In the core logic you want to test the rate limiter functionality. It is easier to represent with something like
rate: 1000
cctxs: [{type: zeta, amount: 500}, ...]
There was a problem hiding this comment.
@ws4charlie we need to change the logic to use smaller unit unit like azeta.
I made the change here for ZETA: #2063
This is why the unit tests are failing
We need to do the same with gas and ZRC20
Thie was just resolved in c011900 |
* add skip header option * use option for migration test * move bitcoin addresses tests to advanced * show cctx in logs * update version * fix verification flags error
* refactor and create Withdraw ZETA general function * new rate limiter test * use rate limiter for admin test * fix the test: single approval and add liquidity * make generate * fix liquidity * fix uniswap pool * change localnet chain params * fix lint * add cli query * add nil check * fix nil point * modify tests * eliminate nil pending nonce issue * fix query * set flags * Update e2e/runner/evm.go Co-authored-by: Charlie Chen <[email protected]> * add back other advanced tests * make generate * add comment * fix eth liquidity cap test * fix withdraw count --------- Co-authored-by: Charlie Chen <[email protected]> Co-authored-by: Charlie Chen <[email protected]>
There was a problem hiding this comment.
Looks good, tested a last time in the CI: https://github.com/zeta-chain/node/actions/runs/8898407760/job/24435481261
* refactor: allow zeta deposits to new zevm address (#2076) * allow zevm coin deposit to unknow addresses * add e2e tests * add changelog * add comments * test(e2e): fix local e2e upgrade test (#2099) * add skip header option * use option for migration test * move bitcoin addresses tests to advanced * show cctx in logs * update version * fix verification flags error * update version in changelog * test: fix and unit tests for query pending cctx within rate limit (#2060) * initial commit of grpc pending cctx query with rate limiter * replace big.Float with sdk.Dec and update mock rate limiter flags * split big loop into backwards loop and forwards loop to be more accurate * adjust zetaclient code to query pending cctx with rate limit * update change log and add one more rate limiter flag test * use outboun amount for calculation * some minimum code refactor * created separate file for cctx query with rate limit * improved a few error handlling * use old cctx query as fallback when rate limiter is disabled; some renaming * fixed unit test compile * added unit test for fallback query * added unit tests for cctx value conversion * add changelog entry * added unit tests for query pending cctxs within rate limit * added total value in rate limiter window for monitoring purpose * Update x/crosschain/keeper/grpc_query_cctx_rate_limit.go Co-authored-by: Lucas Bertrand <[email protected]> * change variable name fCoin to foreignCoin * Update x/fungible/keeper/foreign_coins.go Co-authored-by: Lucas Bertrand <[email protected]> * Update x/crosschain/keeper/grpc_query_cctx_rate_limit_test.go Co-authored-by: Lucas Bertrand <[email protected]> * converted rate limiter query unit tests to table test * handle edge case when pending cctxs span wider block range than sliding window * added zero rate check; added comment to make unit test clearer * added unit test and note for method GetAllForeignCoinMap * treat Rate as average block rate; stop outbound when current rate limit exceeds Rate; updated metrics * add commented unit tests back * replace sdk.Dec with sdkmath.Int to represent cctx value in azeta * test: disable header proof test in local upgrade test E2E test (#2051) * add skip header option * use option for migration test * move bitcoin addresses tests to advanced * show cctx in logs * update version * fix verification flags error * test(e2e): add rate limiter admin E2E test (#2063) * refactor and create Withdraw ZETA general function * new rate limiter test * use rate limiter for admin test * fix the test: single approval and add liquidity * make generate * fix liquidity * fix uniswap pool * change localnet chain params * fix lint * add cli query * add nil check * fix nil point * modify tests * eliminate nil pending nonce issue * fix query * set flags * Update e2e/runner/evm.go Co-authored-by: Charlie Chen <[email protected]> * add back other advanced tests * make generate * add comment * fix eth liquidity cap test * fix withdraw count --------- Co-authored-by: Charlie Chen <[email protected]> Co-authored-by: Charlie Chen <[email protected]> * removed incorrect Note * improved variable name * add E2E test for rate limiter gas and erc20 * remove outdated comment --------- Co-authored-by: Lucas Bertrand <[email protected]> * more conflict resolution --------- Co-authored-by: Tanmay <[email protected]> Co-authored-by: Lucas Bertrand <[email protected]> Co-authored-by: Alex Gartner <[email protected]>
Description
Add unit tests for outbound rate limiter
Done:
Closes: #2061
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: