Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e): fix liquidity cap advanced test #2047

Merged
merged 4 commits into from
Apr 23, 2024
Merged

test(e2e): fix liquidity cap advanced test #2047

merged 4 commits into from
Apr 23, 2024

Conversation

lumtis
Copy link
Member

@lumtis lumtis commented Apr 18, 2024

Description

  • Create a specific file for the test
  • Fix the test by using liquidityCapArg instead of liquidityCap for calculating the diff for test cases

Closes: #2009

@lumtis
Copy link
Member Author

lumtis commented Apr 18, 2024

Successful execution: https://github.com/zeta-chain/node/actions/runs/8740729416

@lumtis lumtis merged commit f4f5cd6 into develop Apr 23, 2024
21 checks passed
@lumtis lumtis deleted the fix/advanced-test-liquidity branch April 23, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingpinXD kingpinXD kingpinXD approved these changes

@skosito skosito skosito approved these changes

@brewmaster012 brewmaster012 Awaiting requested review from brewmaster012

@ws4charlie ws4charlie Awaiting requested review from ws4charlie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Admin E2E test update liquidity cap fails
3 participants
@lumtis @skosito @kingpinXD