Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: zevm message passing #2034

Merged
merged 33 commits into from
Apr 19, 2024
Merged

feat: zevm message passing #2034

merged 33 commits into from
Apr 19, 2024

Conversation

kingpinXD
Copy link
Contributor

@kingpinXD kingpinXD commented Apr 15, 2024

Description

The PR adds

Note: Adding some more unit tests to increase coverage is still pending, but marking this for review as e2e tests are working and this pr should be included in the audit

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still in draft but adding some suggestions

x/crosschain/keeper/evm_deposit.go Outdated Show resolved Hide resolved
x/fungible/keeper/zevm_msg_passing.go Outdated Show resolved Hide resolved
x/fungible/keeper/zevm_msg_passing.go Show resolved Hide resolved
x/fungible/keeper/zevm_msg_passing.go Show resolved Hide resolved
x/fungible/keeper/zevm_msg_passing.go Outdated Show resolved Hide resolved
x/fungible/keeper/zevm_msg_passing.go Show resolved Hide resolved
x/fungible/keeper/zevm_msg_passing.go Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Apr 16, 2024

!!!WARNING!!!
nosec detected in the following files: x/crosschain/keeper/cctx.go, x/crosschain/keeper/processs_outbound.go

Be very careful about using #nosec in code. It can be a quick way to suppress security warnings and move forward with development, it should be employed with caution. Suppressing warnings with #nosec can hide potentially serious vulnerabilities. Only use #nosec when you're absolutely certain that the security issue is either a false positive or has been mitigated in another way.

Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203
Broad #nosec annotations should be avoided, as they can hide other vulnerabilities. The CI will block you from merging this PR until you remove #nosec annotations that do not target specific rules.

Pay extra attention to the way #nosec is being used in the files listed above.

@github-actions github-actions bot added the nosec label Apr 16, 2024
Copy link
Contributor

@skosito skosito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just couple of small comments, main purpose of review was to do first pass to get familiar with this PR even though it is draft phase, will do another review when its ready for review

e2e/e2etests/e2etests.go Outdated Show resolved Hide resolved
testutil/contracts/Dapp.sol Show resolved Hide resolved
zetaclient/evm/evm_signer.go Show resolved Hide resolved
x/fungible/keeper/zevm_msg_passing.go Outdated Show resolved Hide resolved
x/fungible/keeper/zevm_msg_passing.go Show resolved Hide resolved
@kingpinXD kingpinXD requested review from lumtis and skosito April 19, 2024 05:09
@kingpinXD kingpinXD marked this pull request as ready for review April 19, 2024 05:25
e2e/e2etests/test_eth_deposit.go Outdated Show resolved Hide resolved
e2e/e2etests/test_eth_deposit.go Outdated Show resolved Hide resolved
e2e/e2etests/test_message_passing_zevm.go Show resolved Hide resolved
e2e/e2etests/test_message_passing_zevm.go Show resolved Hide resolved
e2e/e2etests/test_message_passing_zevm.go Outdated Show resolved Hide resolved
x/crosschain/keeper/cctx.go Outdated Show resolved Hide resolved
x/crosschain/keeper/evm_deposit.go Outdated Show resolved Hide resolved
x/crosschain/keeper/processs_outbound.go Show resolved Hide resolved
x/fungible/keeper/evm.go Outdated Show resolved Hide resolved
x/fungible/keeper/evm.go Outdated Show resolved Hide resolved
Replace error code duplicated to fix the execution error
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 84.31373% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 71.32%. Comparing base (1051a31) to head (ee8142e).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2034      +/-   ##
===========================================
+ Coverage    71.25%   71.32%   +0.06%     
===========================================
  Files          250      251       +1     
  Lines        13712    13868     +156     
===========================================
+ Hits          9771     9891     +120     
- Misses        3495     3517      +22     
- Partials       446      460      +14     
Files Coverage Δ
x/crosschain/keeper/cctx.go 94.11% <100.00%> (ø)
x/crosschain/keeper/evm_hooks.go 82.70% <100.00%> (+0.09%) ⬆️
x/crosschain/keeper/gas_payment.go 80.64% <ø> (ø)
x/crosschain/keeper/msg_server_vote_outbound_tx.go 92.30% <ø> (ø)
x/crosschain/keeper/process_inbound.go 100.00% <100.00%> (ø)
x/fungible/keeper/deposits.go 95.00% <100.00%> (+0.26%) ⬆️
x/fungible/keeper/system_contract.go 88.88% <100.00%> (+0.02%) ⬆️
x/fungible/keeper/zeta.go 100.00% <100.00%> (ø)
x/fungible/keeper/zevm_msg_passing.go 100.00% <100.00%> (ø)
zetaclient/zetabridge/tx_vote_inbound.go 100.00% <ø> (ø)
... and 5 more

... and 1 file with indirect coverage changes

cmd/zetae2e/local/local.go Outdated Show resolved Hide resolved
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Just need to fix the lint

@lumtis lumtis merged commit fe916e2 into develop Apr 19, 2024
19 checks passed
@lumtis lumtis deleted the zevm-message-passing branch April 19, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants