-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: zevm message passing #2034
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still in draft but adding some suggestions
!!!WARNING!!! Be very careful about using Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203 Pay extra attention to the way |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just couple of small comments, main purpose of review was to do first pass to get familiar with this PR even though it is draft phase, will do another review when its ready for review
Replace error code duplicated to fix the execution error
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2034 +/- ##
===========================================
+ Coverage 71.25% 71.32% +0.06%
===========================================
Files 250 251 +1
Lines 13712 13868 +156
===========================================
+ Hits 9771 9891 +120
- Misses 3495 3517 +22
- Partials 446 460 +14
|
Co-authored-by: Lucas Bertrand <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Just need to fix the lint
Description
The PR adds
Closes:Message passing: allow to call contract on ZetaChain from Zeta CCTX #1803
Message passing: allow to call contract on external chain from ZetaChain #1804
Add E2E test zEVM -> external chain message passing #1834
Add E2E test external chain -> zEVM message passing #1835
Note: Adding some more unit tests to increase coverage is still pending, but marking this for review as e2e tests are working and this pr should be included in the audit
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: