-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replaced hard-coded MaxLookaheadNonce with a default lookback factor #2033
Conversation
!!!WARNING!!! Be very careful about using Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203 Pay extra attention to the way |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2033 +/- ##
===========================================
- Coverage 69.96% 69.96% -0.01%
===========================================
Files 249 249
Lines 14039 14040 +1
===========================================
Hits 9823 9823
- Misses 3758 3759 +1
Partials 458 458
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some comments about name changes, but looks good
Description
MaxLookaheadNonce
120 works for Ethereum but won't make sense for other EVM chains. The PR replaced theMaxLookaheadNonce
with defaultlookback
factor.Closes: 1484
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: