Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replaced hard-coded MaxLookaheadNonce with a default lookback factor #2033

Merged
merged 8 commits into from
Apr 30, 2024

Conversation

ws4charlie
Copy link
Contributor

Description

  1. The hard-coded MaxLookaheadNonce 120 works for Ethereum but won't make sense for other EVM chains. The PR replaced the MaxLookaheadNonce with default lookback factor.
  2. The newly calculated number will be same as the existing number used for Ethereum mainnet.

Closes: 1484

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

Copy link

!!!WARNING!!!
nosec detected in the following files: zetaclient/zetacore_observer.go

Be very careful about using #nosec in code. It can be a quick way to suppress security warnings and move forward with development, it should be employed with caution. Suppressing warnings with #nosec can hide potentially serious vulnerabilities. Only use #nosec when you're absolutely certain that the security issue is either a false positive or has been mitigated in another way.

Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203
Broad #nosec annotations should be avoided, as they can hide other vulnerabilities. The CI will block you from merging this PR until you remove #nosec annotations that do not target specific rules.

Pay extra attention to the way #nosec is being used in the files listed above.

@github-actions github-actions bot added the nosec label Apr 15, 2024
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 69.96%. Comparing base (379a056) to head (93f74c0).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2033      +/-   ##
===========================================
- Coverage    69.96%   69.96%   -0.01%     
===========================================
  Files          249      249              
  Lines        14039    14040       +1     
===========================================
  Hits          9823     9823              
- Misses        3758     3759       +1     
  Partials       458      458              
Files Coverage Δ
zetaclient/zetacore_observer.go 16.58% <0.00%> (-0.08%) ⬇️

zetaclient/zetacore_observer.go Outdated Show resolved Hide resolved
zetaclient/zetacore_observer.go Outdated Show resolved Hide resolved
Copy link
Contributor

@skosito skosito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments about name changes, but looks good

zetaclient/zetacore_observer.go Outdated Show resolved Hide resolved
@lumtis lumtis merged commit e620348 into develop Apr 30, 2024
20 of 21 checks passed
@lumtis lumtis deleted the fix-MaxLookaheadNonce branch April 30, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider combining parameters of 'MaxLookaheadNonce' and 'OutboundTxScheduleLookahead'
4 participants