Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(crosschain): rename GasPriceVoter to VoteGasPrice #2013

Merged
merged 5 commits into from
Apr 15, 2024

Conversation

lumtis
Copy link
Member

@lumtis lumtis commented Apr 11, 2024

Everything in the title

Addressing this now since it complete a series of message renaming we recently did.

Closes: #1925

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.54%. Comparing base (637c62e) to head (3194f79).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2013   +/-   ##
========================================
  Coverage    68.54%   68.54%           
========================================
  Files          236      236           
  Lines        13620    13620           
========================================
  Hits          9336     9336           
  Misses        3834     3834           
  Partials       450      450           
Files Coverage Δ
x/crosschain/keeper/msg_server_vote_gas_price.go 100.00% <100.00%> (ø)
x/crosschain/types/authz.go 100.00% <100.00%> (ø)
x/crosschain/types/message_vote_gas_price.go 100.00% <100.00%> (ø)
zetaclient/zetabridge/tx.go 52.65% <100.00%> (ø)

@lumtis lumtis marked this pull request as ready for review April 11, 2024 13:01
Copy link

!!!WARNING!!!
nosec detected in the following files: zetaclient/zetabridge/tx.go, x/crosschain/keeper/msg_server_vote_gas_price.go

Be very careful about using #nosec in code. It can be a quick way to suppress security warnings and move forward with development, it should be employed with caution. Suppressing warnings with #nosec can hide potentially serious vulnerabilities. Only use #nosec when you're absolutely certain that the security issue is either a false positive or has been mitigated in another way.

Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203
Broad #nosec annotations should be avoided, as they can hide other vulnerabilities. The CI will block you from merging this PR until you remove #nosec annotations that do not target specific rules.

Pay extra attention to the way #nosec is being used in the files listed above.

@github-actions github-actions bot added the nosec label Apr 11, 2024
Copy link
Contributor

@ws4charlie ws4charlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lumtis lumtis merged commit 418c7e8 into develop Apr 15, 2024
21 checks passed
@lumtis lumtis deleted the refactor/vote-gas-price branch April 15, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename GasPriceVoter to VoteGasPrice
3 participants