Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve fungible module coverage #1985

Merged
merged 7 commits into from
Apr 5, 2024
Merged

Conversation

skosito
Copy link
Contributor

@skosito skosito commented Apr 4, 2024

Description

Bumps fungible module coverage from 80 to 90%. Coverage was already improved before (#1742), but this improves it a bit more. This is also last issue in the epic #1739 so epic can also be closed when this is merged.

Closes: #1977

Type of change

Tests

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.11%. Comparing base (9eb55e7) to head (4213c41).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1985      +/-   ##
===========================================
+ Coverage    63.91%   65.11%   +1.20%     
===========================================
  Files          236      236              
  Lines        13639    13610      -29     
===========================================
+ Hits          8717     8862     +145     
+ Misses        4505     4375     -130     
+ Partials       417      373      -44     
Files Coverage Δ
x/fungible/keeper/evm.go 87.43% <100.00%> (+18.35%) ⬆️
x/fungible/keeper/evm_hooks.go 100.00% <100.00%> (+20.00%) ⬆️
x/fungible/keeper/gas_coin_and_pool.go 89.04% <ø> (+24.65%) ⬆️

... and 9 files with indirect coverage changes

@skosito skosito marked this pull request as ready for review April 4, 2024 15:28
@skosito
Copy link
Contributor Author

skosito commented Apr 4, 2024

@lumtis are params used for this module or is it same as crosschain and should be removed?

Copy link
Contributor

@kingpinXD kingpinXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm , left a few minor comments

@skosito skosito requested a review from kingpinXD April 4, 2024 22:27
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lumtis lumtis merged commit 131a774 into develop Apr 5, 2024
21 checks passed
@lumtis lumtis deleted the test-fungible-module branch April 5, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase fungible module coverage
3 participants