-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: improve fungible module coverage #1985
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1985 +/- ##
===========================================
+ Coverage 63.91% 65.11% +1.20%
===========================================
Files 236 236
Lines 13639 13610 -29
===========================================
+ Hits 8717 8862 +145
+ Misses 4505 4375 -130
+ Partials 417 373 -44
|
@lumtis are params used for this module or is it same as crosschain and should be removed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm , left a few minor comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Description
Bumps fungible module coverage from 80 to 90%. Coverage was already improved before (#1742), but this improves it a bit more. This is also last issue in the epic #1739 so epic can also be closed when this is merged.
Closes: #1977
Type of change
Tests
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: