Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add command to modify genesis before import #1979

Merged
merged 22 commits into from
Apr 19, 2024
Merged

Conversation

kingpinXD
Copy link
Contributor

Description

  • Adds a command to zeta cored which accepts two genesis files

    1. A newly created genesis file to start a network
    2. An exported genesis file

    It copies over the required data from the exported file so that the genesis file can be used to start a network with some state data.

Closes: #1422

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@lumtis
Copy link
Member

lumtis commented Apr 8, 2024

@CharlieMc0 for new suggestions

@kingpinXD kingpinXD marked this pull request as ready for review April 12, 2024 05:36
@kingpinXD kingpinXD requested a review from gzukel April 12, 2024 05:37
@kingpinXD kingpinXD marked this pull request as draft April 12, 2024 15:10
@kingpinXD kingpinXD marked this pull request as ready for review April 12, 2024 16:56
cmd/zetacored/root.go Show resolved Hide resolved
cmd/zetacored/parse_genesis.go Outdated Show resolved Hide resolved
cmd/zetacored/parse_genesis.go Outdated Show resolved Hide resolved
Copy link
Contributor

@skosito skosito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just couple of comments, mainly to add some details on modification part for clarity

cmd/zetacored/parse_genesis.go Show resolved Hide resolved
cmd/zetacored/parse_genesis.go Outdated Show resolved Hide resolved
cmd/zetacored/parse_genesis.go Show resolved Hide resolved
@kingpinXD kingpinXD requested review from lumtis and skosito April 17, 2024 16:17
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me if it has been tested live

cmd/zetacored/parse_genesis.go Outdated Show resolved Hide resolved
@lumtis lumtis merged commit fb05f0d into develop Apr 19, 2024
21 checks passed
@lumtis lumtis deleted the genesis-import branch April 19, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Native SDK Local Network State Export
3 participants