fix: check crosschain flags to stop inbound/outbound; get rid of outtx tracker iteration timeout

[ws4charlie]

Description

• Zetaclient will check crosschain flags to stop inbound/outbound txs (both EVM chain and Bitcoin):
  • stop EVM/BTC intx observation and intx tracker processing.
  • stop EVM/BTC outtx keysign.
  • stop EVMBTC outtx tracker processing.
• Removed the timeout logic when iterating thru EVM chain outtx trackers.
• Unified logic of the method WatchGasPrice for EVM chain and Bitcoin chain.

Closes: 1888, 1970

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

• Tested CCTX in localnet
• Tested in development environment
• Go unit tests
• Go integration tests
• Tested via GitHub Actions

Checklist:

• I have added unit tests that prove my fix feature works

[github-actions]

!!!WARNING!!!
nosec detected in the following files: zetaclient/zetacore_observer.go

Be very careful about using #nosec in code. It can be a quick way to suppress security warnings and move forward with development, it should be employed with caution. Suppressing warnings with #nosec can hide potentially serious vulnerabilities. Only use #nosec when you're absolutely certain that the security issue is either a false positive or has been mitigated in another way.

Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203
Broad #nosec annotations should be avoided, as they can hide other vulnerabilities. The CI will block you from merging this PR until you remove #nosec annotations that do not target specific rules.

Pay extra attention to the way #nosec is being used in the files listed above.

[lumtis]

It seems that the test failures are related to the change @ws4charlie

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 60 lines in your changes are missing coverage. Please review.

Project coverage is 63.08%. Comparing base (fca927f) to head (4a5350c).
Report is 1 commits behind head on develop.

❗ Current head 4a5350c differs from pull request most recent head 3b4f787. Consider uploading reports for the commit 3b4f787 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1978      +/-   ##
===========================================
- Coverage    63.08%   63.08%   -0.01%     
===========================================
  Files          233      233              
  Lines        13381    13376       -5     
===========================================
- Hits          8442     8438       -4     
+ Misses        4540     4539       -1     
  Partials       399      399              

Files	Coverage Δ
zetaclient/bitcoin/inbound_tracker.go	0.00% <0.00%> (ø)
zetaclient/evm/inbounds.go	69.32% <0.00%> (-0.59%)	⬇️
zetaclient/bitcoin/bitcoin_client.go	16.05% <0.00%> (-0.59%)	⬇️
zetaclient/evm/evm_client.go	15.18% <0.00%> (+0.29%)	⬆️
zetaclient/zetacore_observer.go	18.00% <0.00%> (-0.10%)	⬇️

[kevinssgh]

Looks good. I think it might be difficult to unit test some of these go routines and loops. Should probably look into making this easier later on.

[lumtis]

Looks good. I think it might be difficult to unit test some of these go routines and loops. Should probably look into making this easier later on.

Yes, startCctxScheduler should definitely be simplified

[ws4charlie]

The diff view of this PR was somehow messed up. So I re-created the PR as #1984