Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: evm signer tests were failing intermittently in CI #1944

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

kevinssgh
Copy link
Contributor

@kevinssgh kevinssgh commented Mar 25, 2024

Description

Changed test eth signer type to support more transaction types.

Closes: #1887

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.12%. Comparing base (8146f92) to head (4563ace).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1944   +/-   ##
========================================
  Coverage    52.12%   52.12%           
========================================
  Files          235      235           
  Lines        13347    13347           
========================================
  Hits          6957     6957           
  Misses        5953     5953           
  Partials       437      437           
Files Coverage Δ
zetaclient/evm/evm_signer.go 48.44% <100.00%> (ø)

@kevinssgh kevinssgh merged commit a225b9d into develop Mar 25, 2024
21 checks passed
@kevinssgh kevinssgh deleted the fix_evm_tests branch March 25, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

evm_signer_test in ZetaClient sometimes fail
3 participants