-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace common package with pkg #1936
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1936 +/- ##
===========================================
- Coverage 52.12% 51.92% -0.21%
===========================================
Files 235 235
Lines 13347 13347
===========================================
- Hits 6957 6930 -27
- Misses 5953 5982 +29
+ Partials 437 435 -2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems most of the content in cosmos.go
is unused and can be removed (you can see those with Goland for ex)
I might even think this package is not needed anymore but removing it might be higher than the scope of this PR
@lumtis regarding cosmos package, i removed unused and replaced some usages to use sdk types directly dcb3b5a only thing left in cosmos package are some legacybech32 methods, i thought to maybe leave them there instead of having legacy package imported on couple of places, and we can maybe open issue to replace those deprecated methods with proper ones? |
This sounds good to me |
Description
Its a big PR, but the only place to review is
common
package renaming topkg
and split into subpackages (couple of files like commands, version and constant are still inpkg
package).Because of this split, i also did the same for
common
proto files, now calledpkg
too.Best way to review this is to check it out locally and check proto and pkg files, eg. if organization in subpackages in ok, if naming of subpackages is ok etc - the rest of the changes are just fixing imports (apart from proof test which i will flag in the comment).
Closes: #1905
Type of change
Refactor
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: