Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new operational authority group #1935

Merged
merged 18 commits into from
Mar 27, 2024
Merged

Conversation

lumtis
Copy link
Member

@lumtis lumtis commented Mar 22, 2024

Description

  • Add a operational authority group for operational purpose (non-sensitive network param changes)
  • Move all the admin messages to operational messages except the following which are sensitive as discussed in the doc:
    • MsgUpdateTssAddress
    • MsgUpdateContractBytecode
    • MsgUpdateSystemContract
    • MsgMigrateTssFunds

Change the migration script to set the current group 2 address to group admin and operational at the same time. The operational address should be changed with a gov prop later (with less required signatures)

Closes: #1715

Copy link

!!!WARNING!!!
nosec detected in the following files: x/observer/keeper/msg_server_update_observer_test.go

Be very careful about using #nosec in code. It can be a quick way to suppress security warnings and move forward with development, it should be employed with caution. Suppressing warnings with #nosec can hide potentially serious vulnerabilities. Only use #nosec when you're absolutely certain that the security issue is either a false positive or has been mitigated in another way.

Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203
Broad #nosec annotations should be avoided, as they can hide other vulnerabilities. The CI will block you from merging this PR until you remove #nosec annotations that do not target specific rules.

Pay extra attention to the way #nosec is being used in the files listed above.

@github-actions github-actions bot added the nosec label Mar 22, 2024
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 51.95%. Comparing base (f693378) to head (d5ed973).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1935      +/-   ##
===========================================
+ Coverage    51.92%   51.95%   +0.03%     
===========================================
  Files          235      235              
  Lines        13347    13357      +10     
===========================================
+ Hits          6930     6940      +10     
  Misses        5982     5982              
  Partials       435      435              
Files Coverage Δ
x/authority/types/policies.go 100.00% <100.00%> (ø)
x/crosschain/keeper/msg_server_abort_stuck_cctx.go 100.00% <100.00%> (ø)
...rosschain/keeper/msg_server_add_to_intx_tracker.go 51.85% <100.00%> (ø)
.../crosschain/keeper/msg_server_refund_aborted_tx.go 89.18% <100.00%> (ø)
x/crosschain/keeper/msg_server_whitelist_erc20.go 82.14% <100.00%> (ø)
...le/keeper/msg_server_deploy_fungible_coin_zrc20.go 94.11% <100.00%> (ø)
...ngible/keeper/msg_server_deploy_system_contract.go 67.44% <100.00%> (ø)
.../fungible/keeper/msg_server_remove_foreign_coin.go 100.00% <100.00%> (ø)
...le/keeper/msg_server_udpate_zrc20_liquidity_cap.go 100.00% <100.00%> (ø)
...ible/keeper/msg_server_update_contract_bytecode.go 92.50% <100.00%> (ø)
... and 22 more

@lumtis lumtis requested a review from kingpinXD March 26, 2024 10:06
Copy link
Contributor

@skosito skosito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just 2 nits

app/ante/ante.go Show resolved Hide resolved
x/observer/keeper/msg_server_add_blame_vote.go Outdated Show resolved Hide resolved
@lumtis lumtis merged commit 5504e41 into develop Mar 27, 2024
21 checks passed
@lumtis lumtis deleted the feat/new-operational-group branch March 27, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a new policy group for operational purpose
3 participants