-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new operational authority group #1935
Conversation
!!!WARNING!!! Be very careful about using Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203 Pay extra attention to the way |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1935 +/- ##
===========================================
+ Coverage 51.92% 51.95% +0.03%
===========================================
Files 235 235
Lines 13347 13357 +10
===========================================
+ Hits 6930 6940 +10
Misses 5982 5982
Partials 435 435
|
Co-authored-by: Tanmay <[email protected]>
Co-authored-by: Tanmay <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just 2 nits
Description
MsgUpdateTssAddress
MsgUpdateContractBytecode
MsgUpdateSystemContract
MsgMigrateTssFunds
Change the migration script to set the current group 2 address to group admin and operational at the same time. The operational address should be changed with a gov prop later (with less required signatures)
Closes: #1715