Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add reset chain nonces msg #1919

Merged
merged 8 commits into from
Mar 21, 2024
Merged

feat: add reset chain nonces msg #1919

merged 8 commits into from
Mar 21, 2024

Conversation

skosito
Copy link
Contributor

@skosito skosito commented Mar 20, 2024

Description

Cherry picks commits for new message from #1912 (NOTE: without upgrade handler part).

There are some differences here compared to #1912 -ResetChainNonces and related tests are modified here to use authority module, which was not available on v14.0.1.

Closes: #1911

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

Copy link

!!!WARNING!!!
nosec detected in the following files: x/observer/keeper/msg_server_reset_chain_nonces.go

Be very careful about using #nosec in code. It can be a quick way to suppress security warnings and move forward with development, it should be employed with caution. Suppressing warnings with #nosec can hide potentially serious vulnerabilities. Only use #nosec when you're absolutely certain that the security issue is either a false positive or has been mitigated in another way.

Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203
Broad #nosec annotations should be avoided, as they can hide other vulnerabilities. The CI will block you from merging this PR until you remove #nosec annotations that do not target specific rules.

Pay extra attention to the way #nosec is being used in the files listed above.

@github-actions github-actions bot added the nosec label Mar 20, 2024
@skosito skosito marked this pull request as ready for review March 20, 2024 19:06
changelog.md Outdated Show resolved Hide resolved
@skosito skosito marked this pull request as draft March 20, 2024 19:11
@skosito skosito marked this pull request as ready for review March 20, 2024 19:46
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.43%. Comparing base (39bca23) to head (1264a47).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1919      +/-   ##
===========================================
+ Coverage    48.16%   48.43%   +0.26%     
===========================================
  Files          233      235       +2     
  Lines        13322    13377      +55     
===========================================
+ Hits          6417     6479      +62     
+ Misses        6463     6456       -7     
  Partials       442      442              
Files Coverage Δ
x/observer/keeper/msg_server_reset_chain_nonces.go 100.00% <100.00%> (ø)
x/observer/types/message_reset_chain_nonces.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

changelog.md Outdated Show resolved Hide resolved
@skosito skosito requested a review from lumtis March 21, 2024 11:28
@skosito skosito merged commit 1655c34 into develop Mar 21, 2024
21 checks passed
@skosito skosito deleted the feat-reset-nonces-msg branch March 21, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement MsgResetChainNonces
3 participants