-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: improve common package coverage #1903
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1903 +/- ##
===========================================
+ Coverage 48.82% 52.12% +3.30%
===========================================
Files 235 235
Lines 13381 13347 -34
===========================================
+ Hits 6533 6957 +424
+ Misses 6405 5953 -452
+ Partials 443 437 -6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, great 👍
I think we can also do #1905 for the code structure. But this can be done in another PR
sure, i can do this structure task once this is merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left minor comments
LGTM
tnx, fixed |
Description
note: too many files changed in diff because i moved some files (81 receipts.json files) and added files for transactions data (81 tx.json files)
Closes: #1833
Type of change
New tests
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: