Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): add testing for external chain migration #1900

Merged
merged 40 commits into from
Apr 4, 2024

Conversation

lumtis
Copy link
Member

@lumtis lumtis commented Mar 15, 2024

Description

The test spinup another EVM network, initialize the first one first then try initializing the second, adding it as supported chain and removing support for first chain.

Closes: #1896

Copy link

gitguardian bot commented Mar 20, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Copy link

!!!WARNING!!!
nosec detected in the following files: cmd/zetae2e/local/accounts.go, e2e/e2etests/e2etests.go

Be very careful about using #nosec in code. It can be a quick way to suppress security warnings and move forward with development, it should be employed with caution. Suppressing warnings with #nosec can hide potentially serious vulnerabilities. Only use #nosec when you're absolutely certain that the security issue is either a false positive or has been mitigated in another way.

Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203
Broad #nosec annotations should be avoided, as they can hide other vulnerabilities. The CI will block you from merging this PR until you remove #nosec annotations that do not target specific rules.

Pay extra attention to the way #nosec is being used in the files listed above.

@github-actions github-actions bot added the nosec label Mar 22, 2024
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 63.91%. Comparing base (f845afc) to head (59325b2).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1900   +/-   ##
========================================
  Coverage    63.90%   63.91%           
========================================
  Files          236      236           
  Lines        13631    13639    +8     
========================================
+ Hits          8711     8717    +6     
- Misses        4504     4505    +1     
- Partials       416      417    +1     
Files Coverage Δ
x/observer/keeper/msg_server_reset_chain_nonces.go 100.00% <ø> (ø)
zetaclient/config/config_chain.go 0.00% <ø> (ø)
zetaclient/evm/evm_signer.go 48.44% <ø> (ø)
x/crosschain/keeper/msg_server_whitelist_erc20.go 81.66% <75.00%> (-0.48%) ⬇️

@lumtis lumtis marked this pull request as ready for review March 25, 2024 21:40
contrib/localnet/scripts/start-zetaclientd.sh Outdated Show resolved Hide resolved
e2e/utils/zetacore.go Show resolved Hide resolved
zetaclient/evm/evm_signer.go Outdated Show resolved Hide resolved
Copy link
Contributor

@skosito skosito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, approved with 2 small comments, please check if they make sense

@lumtis
Copy link
Member Author

lumtis commented Apr 3, 2024

lgtm, approved with 2 small comments, please check if they make sense

Implemented the suggestion

@lumtis lumtis merged commit 9eb55e7 into develop Apr 4, 2024
21 checks passed
@lumtis lumtis deleted the e2e-new-chain-support branch April 4, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Work on an admin E2E test to simulate adding a new chain and removing chain support
4 participants