Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add empty test files so packages are included in coverage #1899

Merged
merged 4 commits into from
Mar 15, 2024

Conversation

skosito
Copy link
Contributor

@skosito skosito commented Mar 14, 2024

Description

Add empty test files in packages without any tests so they are included in coverage with 0%, instead of completely ignored.
This is added only for packages that are supposed to be included (cross checked with ignored files in codecov).

Check issue for more information on why is this needed.

For reference, codecov report for this branch: https://app.codecov.io/gh/zeta-chain/node/tree/test-add-missing-test-files/zetaclient
vs codecov report for develop branch: https://app.codecov.io/gh/zeta-chain/node/tree/develop/
(check packages where empty test files are added in this PR, they are ignored on develop codecov)

Closes: #1893

Type of change

Tests

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.55%. Comparing base (a824f4e) to head (c09ee5e).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1899      +/-   ##
===========================================
- Coverage    49.95%   48.55%   -1.40%     
===========================================
  Files          220      232      +12     
  Lines        12722    13098     +376     
===========================================
+ Hits          6355     6360       +5     
- Misses        5925     6296     +371     
  Partials       442      442              

see 12 files with indirect coverage changes

@skosito skosito merged commit f2fde15 into develop Mar 15, 2024
20 of 21 checks passed
@skosito skosito deleted the test-add-missing-test-files branch March 15, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve reporting of tests coverage
3 participants