-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: zetaclient should pick up new connector and erc20 custody addresses #1890
fix: zetaclient should pick up new connector and erc20 custody addresses #1890
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1890 +/- ##
===========================================
- Coverage 48.55% 48.14% -0.42%
===========================================
Files 232 233 +1
Lines 13098 13317 +219
===========================================
+ Hits 6360 6411 +51
- Misses 6296 6464 +168
Partials 442 442
|
…-zetaclient-update-connector-erc20custody-address
@ws4charlie now the client and signer for each chain update dynamically the chain params? Can we confirm the following?
|
|
We should implement all of this. Let's track issues if those don't exist |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
One comment, and need to address build failure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Description
Closes: 1633
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: