refactor: outboud vote #1886
refactor: outboud vote #1886
Conversation
|
!!!WARNING!!! Be very careful about using Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203 Pay extra attention to the way |
| return nil | ||
| } | ||
|
|
||
| func (k Keeper) FundStabiltityPool(ctx sdk.Context, cctx *types.CrossChainTx) { |
There was a problem hiding this comment.
| func (k Keeper) FundStabiltityPool(ctx sdk.Context, cctx *types.CrossChainTx) { | |
| func (k Keeper) FundStabilityPool(ctx sdk.Context, cctx *types.CrossChainTx) { |
|
|
||
| func (k Keeper) FundStabiltityPool(ctx sdk.Context, cctx *types.CrossChainTx) { | ||
| // Fund the gas stability pool with the remaining funds | ||
| if err := k.FundGasStabilityPoolFromRemainingFees(ctx, *cctx.GetCurrentOutTxParam(), cctx.GetCurrentOutTxParam().ReceiverChainId); err != nil { |
There was a problem hiding this comment.
Is msg.OutTxChain (used before refactor) equal to cctx.GetCurrentOutTxParam().ReceiverChainId) in all cases.
There was a problem hiding this comment.
the pending nonces is set using the receiver chain ID
https://github.com/zeta-chain/zeta-node/blob/75580e7726f421b40be995f3a17de1cce28e338a/x/crosschain/keeper/cctx_utils.go#L105-L118
and the client uses that to query and process outbounds .
https://github.com/zeta-chain/zeta-node/blob/75580e7726f421b40be995f3a17de1cce28e338a/zetaclient/zetacore_observer.go#L145-L149 ,
it should be the same , I can however add an additional check in the outbound message to be safe
kingpinXD
requested review from
brewmaster012,
kevinssgh,
fadeev,
lumtis and
skosito
as code owners
* refactor inbound vote * add unit tests for ProcessZEVMDeposit * creating mocking functions for test refactor * add tests for Process message passing * move cointype to cctx struct and refactor tests to accomodate the change * add defer to recover from panic if config is already set * add more unit tests * add validate * add validate function for cctx * add validate function for cctx * add validate unit tests * add migration test * set module version * fix unit tests * remove unnecessary test * update upgrade docker file * generate files * modify logs * ignore address validation for zetachain * ignore address validation for zetachain * ignore tx hash check * refactor: outboud vote (#1886) * remove changes to cctx struct * modify changelog * add tests for types package * add comments * resolve comments * modify comments based on suggestions * add error message for add revert * replace broken eth rpc * directly modify fungible state in SetupStateForProcessLogsZetaSent * set withdrawals to pending outbound * append status message if not empty * Update changelog.md Co-authored-by: Lucas Bertrand <[email protected]> * add issue #1951 * adjust changelog --------- Co-authored-by: Lucas Bertrand <[email protected]>
Description
MsgVoteOnObservedOutboundTxResponse, to break it down into smaller functionsCloses:#1801
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: