-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(common
): fix and improve Ethereum proof tests
#1872
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumtis
requested review from
brewmaster012,
kingpinXD,
kevinssgh,
fadeev,
ws4charlie and
skosito
as code owners
March 11, 2024 12:20
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1872 +/- ##
===========================================
- Coverage 45.11% 44.62% -0.50%
===========================================
Files 219 219
Lines 12770 12770
===========================================
- Hits 5761 5698 -63
- Misses 6555 6630 +75
+ Partials 454 442 -12 |
skosito
approved these changes
Mar 11, 2024
kingpinXD
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the current unit test failure we have
The reason for the failure was to use Ankr RPC for Goerli for unit test and this endpoint is no longer supported.
We already add an issue to remove use of RPC so this PR replace the RPC usage with static data fetched from Sepolia network.
Some other improvement:
Some other tests related to
MsgBlockHeader
and add trackers don't work when not relying on the RPC. The implementation ofsample.Header
was also incorrect.Since block headers are not yet ready to production in any case, I commented out some of the tests and track it here: #1875
Future tests should mock proof verification
Closes: #1458 #1871