-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: run e2e btc tests locally #1868
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the right way to do it👍
I'm getting this error when trying with the local.yml config
Did you use: This is an error typically happening if the user/pass is incorrect but here it seems to be good. I renamed the user into |
i did this:
and before that could you please share more steps about setup you are doing locally before you are calling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks fine . the broken unit test might already be fixed in a separate pr , which you would need to rebase
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Work well now!
Description
Purpose of this PR is to enable local btc e2e tests to be run separately with
zetae2e run
command.add new command
zetae2e setup-bitcoin [config]
to be run whenever there is "no wallet" error from btc tests (because btc tests can be run locally in various contexts, sometimes wallet will be imported, sometimes not, for example if all local tests are run, running some of them separately will already have wallet) - readme had instructions for this, but it contained docker commands, this way there is cli command for thisfix bitcoin tests that when run manually were missing SetBtcAddress call (some had it, like bitcoin_deposit and stress test deposit)
tested with
make start-localnet
and afterzetae2e setup-bitcoin [config]
all btc tests andbalance
command workedCloses: #1829
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: