Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: default restore_type for full node docker-compose to snapshot instead of statesync for reliability. #1867

Merged
merged 10 commits into from
Mar 11, 2024
Merged

ci: default restore_type for full node docker-compose to snapshot instead of statesync for reliability. #1867

merged 10 commits into from
Mar 11, 2024

Conversation

gzukel
Copy link
Contributor

@gzukel gzukel commented Mar 8, 2024

Description

default restore_type for full node docker-compose to snapshot instead of statesync for reliability.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Yes, this was all tested originally.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions
  • local

Checklist:

  • [N/A] I have added unit tests that prove my fix feature works

lumtis
lumtis approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Changelog need to be put under unreleased. I fixed it.

@gzukel gzukel merged commit 34c586b into develop Mar 11, 2024
24 checks passed
@gzukel gzukel deleted the default-docker-compose-to-snapshot branch March 11, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CryptoFewka CryptoFewka CryptoFewka approved these changes

@CharlieMc0 CharlieMc0 CharlieMc0 approved these changes

@skosito skosito skosito approved these changes

@lumtis lumtis lumtis approved these changes

@brewmaster012 brewmaster012 Awaiting requested review from brewmaster012

@kingpinXD kingpinXD Awaiting requested review from kingpinXD

@kevinssgh kevinssgh Awaiting requested review from kevinssgh

@fadeev fadeev Awaiting requested review from fadeev

@ws4charlie ws4charlie Awaiting requested review from ws4charlie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gzukel @lumtis @skosito @CharlieMc0 @CryptoFewka