-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support Bitcoin P2PKH (legacy), P2SH, P2TR address types #1842
Conversation
added more unit tests
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1842 +/- ##
===========================================
- Coverage 52.12% 48.22% -3.90%
===========================================
Files 235 234 -1
Lines 13347 13412 +65
===========================================
- Hits 6957 6468 -489
- Misses 5953 6487 +534
- Partials 437 457 +20
|
!!!WARNING!!! Be very careful about using Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203 Pay extra attention to the way |
This PR is ported to |
Description
Currently we only support sending to P2WPKH address.
Need to support others.
WIP:
Closes:
1626
1627
1773
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: