-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: removing unnecessary pointers in context structure #1831
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1831 +/- ##
===========================================
+ Coverage 44.80% 45.11% +0.31%
===========================================
Files 218 219 +1
Lines 12689 12779 +90
===========================================
+ Hits 5685 5765 +80
- Misses 6553 6561 +8
- Partials 451 453 +2
|
It's a good direction, I think it simplify the code not using pointer when unnecessary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just some comments on the changelogs
Description
2 parts leftovers from discussions in PR: #1774
add missing unit tests for zeta_core_context
reduce pointers in config/coreContext/appContext
i think pointers should be removed when we want immutability as config, but also considered when there is large struct and mutability (as with core context) so i tried to remove pointers from config struct and also pass config around without pointers (this maybe can be revisited since config might be too big for this?)
Closes: #1807
Type of change
Refactor
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: