Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Dockerfile & Docker Pipeline & Docker Compose Improvements #1821

Merged
merged 20 commits into from
Mar 4, 2024

Conversation

gzukel
Copy link
Contributor

@gzukel gzukel commented Feb 29, 2024

Description

  • Re-wrote Dockerfile for building Zetacored docker images.
  • Adjusted the docker-compose files for Zetacored nodes to utilize the new docker image.
  • Added scripts for the new docker image that facilitate the start up automation.
  • Adjusted the docker pipeline slightly to pull the version on PR from the app.go file.

Closes: DEVOP-408

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • CI Update

How Has This Been Tested?

This was tested via the docker pipeline, and locally by standing up nodes of each network ensuring the automation functioned as intended.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • [N/A] I have added unit tests that prove my fix feature works

@github-actions github-actions bot added the ci Changes to CI pipeline or github actions label Feb 29, 2024
.github/workflows/docker-build-and-push.yml Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile-localnet Show resolved Hide resolved
contrib/docker-scripts/download_binaries.py Show resolved Hide resolved
contrib/docker-scripts/download_binaries.py Outdated Show resolved Hide resolved
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is an issue with the new Dockerfile

COPY failed: stat root/.ssh/localtest.pem.pub: file does not exist

@lumtis lumtis merged commit 01526a5 into develop Mar 4, 2024
20 checks passed
@lumtis lumtis deleted the docker-image-improvements branch March 4, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Changes to CI pipeline or github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants