set mainnet btc deposit fee height to future height #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ws4charlie
requested review from
brewmaster012,
kingpinXD,
kevinssgh,
fadeev,
lumtis and
skosito
as code owners
lumtis
reviewed
Feb 29, 2024
zetaclient/bitcoin/bitcoin_client.go
Outdated
| @@ -38,7 +38,7 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| DynamicDepositorFeeHeight = 832000 // Bitcoin block height to switch to dynamic depositor fee | |||
| DynamicDepositorFeeHeight = 834500 // Bitcoin block height to switch to dynamic depositor fee | |||
There was a problem hiding this comment.
What's the context here? Do we need to update this value for every upgrade moving forward? Would need more comment what the height is used for.
There was a problem hiding this comment.
Only used once for next release. This height the starting height from which dynamic deposit fee will take effect for mainnet (only). I can update the comment.
kingpinXD
approved these changes
Feb 29, 2024
lumtis
added a commit
that referenced
this pull request
Mar 5, 2024
* chore: update v13 changelog * migration script for v14 * tringgger migration4to5 * add more unit test * set version for upgrade test * add logs * replace map with a list * add changelog entry * set mainnet btc deposit fee height to future height (#1818) * update mainnet btc deposit fee height * delay dynamic depositor fee upgrade by 2 weeks * add nosec directives --------- Co-authored-by: Tanmay <[email protected]> Co-authored-by: Charlie Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current upgrade height
832000has already past. We should offset the height to future. I increased the Bitcoin height by2more weeks.Closes:
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: