-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add admin and performance test and fix upgrade test #1805
Conversation
Some bugs in ZetaClient in upgrade tests currently happening, will wait for the ZetaClient refactorings before wrapping it up |
* Refactor zetaclient metrics * Fix blame counter init * Add changelog entry * Add unreleased to changelog * Remove blank line
* initiated feature of zetaclient-banned-address * fix some issues in e2e tests * fix gosec issues * some unit tests, comments and refactor * unified log prints for restricted address detection * move restricted address to Unreleased section * improved compliance log prints * update compliance log print according to CharlieMc
* chore(codecov.yml): fix ignore extension * changelog
* move logic for ballot voting for inbound * fix mocks * goimports * changelog * fix unit tests * fix CI = * x/observer/keeper/vote_outbound.go x/crosschain/types/expected_keepers.go x/crosschain/keeper/msg_server_vote_outbound_tx.go * update mocks * refactor finalized check * make generate * initialize vote inbound tests * add sdk keepers in observer testutil * implement mock option for observer * inbound vote test * initialize outbound tests * goimports * vote outbound tests * update changelog * test with integration tests * add isNew in vote_inbound * add tests back * use tmp context for ballot logic * add new test for finalized ballot * add not finzalized test
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1805 +/- ##
========================================
Coverage 44.62% 44.62%
========================================
Files 219 219
Lines 12770 12771 +1
========================================
+ Hits 5698 5699 +1
Misses 6630 6630
Partials 442 442
|
Performance tests need to be improved: #1854 Already opening the PR so we can already ask DevOps to add the different tests in the CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of minor comments but lgtm
Description
Closes: #1668