Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add admin and performance test and fix upgrade test #1805

Merged
merged 37 commits into from
Mar 12, 2024

Conversation

lumtis
Copy link
Member

@lumtis lumtis commented Feb 23, 2024

Description

  • Implement testing for CCTX performance test
  • Fixes upgrade test for v15
  • Add authority module in setup handler and fix migration
  • Add some fixes in the existing localnet files
  • Add light e2e test option to run upgrade tests

Closes: #1668

@lumtis lumtis linked an issue Feb 23, 2024 that may be closed by this pull request
@lumtis
Copy link
Member Author

lumtis commented Feb 27, 2024

Some bugs in ZetaClient in upgrade tests currently happening, will wait for the ZetaClient refactorings before wrapping it up

kingpinXD and others added 9 commits March 1, 2024 18:25
* Refactor zetaclient metrics

* Fix blame counter init

* Add changelog entry

* Add unreleased to changelog

* Remove blank line
* initiated feature of zetaclient-banned-address

* fix some issues in e2e tests

* fix gosec issues

* some unit tests, comments and refactor

* unified log prints for restricted address detection

* move restricted address to Unreleased section

* improved compliance log prints

* update compliance log print according to CharlieMc
* chore(codecov.yml): fix ignore extension

* changelog
* move logic for ballot voting for inbound

* fix mocks

* goimports

* changelog

* fix unit tests

* fix CI =

* x/observer/keeper/vote_outbound.go x/crosschain/types/expected_keepers.go x/crosschain/keeper/msg_server_vote_outbound_tx.go

* update mocks

* refactor finalized check

* make generate

* initialize vote inbound tests

* add sdk keepers in observer testutil

* implement mock option for observer

* inbound vote test

* initialize outbound tests

* goimports

* vote outbound tests

* update changelog

* test with integration tests

* add isNew in vote_inbound

* add tests back

* use tmp context for ballot logic

* add new test for finalized ballot

* add not finzalized test
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 44.62%. Comparing base (58c3d43) to head (8838ac9).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1805   +/-   ##
========================================
  Coverage    44.62%   44.62%           
========================================
  Files          219      219           
  Lines        12770    12771    +1     
========================================
+ Hits          5698     5699    +1     
  Misses        6630     6630           
  Partials       442      442           
Files Coverage Δ
x/observer/migrations/v7/migrate.go 100.00% <100.00%> (ø)
zetaclient/zetabridge/zetacore_bridge.go 0.00% <0.00%> (ø)

@lumtis lumtis changed the title test: add admin and performance test in the CI test: add admin and performance test and fix upgrade test Mar 6, 2024
@lumtis lumtis marked this pull request as ready for review March 7, 2024 12:54
@lumtis
Copy link
Member Author

lumtis commented Mar 7, 2024

Performance tests need to be improved: #1854

Already opening the PR so we can already ask DevOps to add the different tests in the CI

Copy link
Contributor

@skosito skosito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of minor comments but lgtm

changelog.md Outdated Show resolved Hide resolved
cmd/zetae2e/config/clients.go Show resolved Hide resolved
cmd/zetae2e/config/local.yml Show resolved Hide resolved
cmd/zetae2e/local/ethereum.go Outdated Show resolved Hide resolved
cmd/zetae2e/local/local.go Outdated Show resolved Hide resolved
cmd/zetae2e/local/performance.go Outdated Show resolved Hide resolved
contrib/localnet/docker-compose-performance.yml Outdated Show resolved Hide resolved
cmd/zetae2e/local/local.go Outdated Show resolved Hide resolved
cmd/zetae2e/local/ethereum.go Outdated Show resolved Hide resolved
@lumtis lumtis requested a review from skosito March 10, 2024 15:53
@lumtis lumtis merged commit 71a889b into develop Mar 12, 2024
20 of 21 checks passed
@lumtis lumtis deleted the test/performance-check branch March 12, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TSS signing stress test
4 participants