Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Changes to release-pipeline, adding additional automation for setting up nodes locally. #1757

Merged
merged 28 commits into from
Feb 16, 2024

Conversation

gzukel
Copy link
Contributor

@gzukel gzukel commented Feb 14, 2024

Description

Updates:

  1. Updated the docker build pipeline for MacOS runners to install and run docker for building the image.
  2. Adjusted the docker-compose for mainnet full nodes to have example of how to use the built docker images.
  3. Modified the release-pipeline to follow the new release process with a manually executed pipeline with the ability to skip tests if emergency and the addition of an approval step.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I executed the docker build pipeline from my branch to make sure changes worked for MacOS: https://github.com/zeta-chain/node/actions/runs/7893088980

I executed docker-compose locally to ensure the full-node synced with state-sync from the already built docker image.

I tested the updated publish release pipeline. I tested the skip tests works and the approval step works.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • [N/A] I have added unit tests that prove my fix feature works

@github-actions github-actions bot added the ci Changes to CI pipeline or github actions label Feb 14, 2024
changelog.md Outdated Show resolved Hide resolved
…ers, updated the docker-compose with comments and examples to use exsiting docker image or build current git ref
changelog.md Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Feb 15, 2024

!!!WARNING!!!
nosec detected in the following files: .github/workflows/publish-release.yml

Be very careful about using #nosec in code. It can be a quick way to suppress security warnings and move forward with development, it should be employed with caution. Suppressing warnings with #nosec can hide potentially serious vulnerabilities. Only use #nosec when you're absolutely certain that the security issue is either a false positive or has been mitigated in another way.

Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203
Broad #nosec annotations should be avoided, as they can hide other vulnerabilities. The CI will block you from merging this PR until you remove #nosec annotations that do not target specific rules.

Pay extra attention to the way #nosec is being used in the files listed above.

@github-actions github-actions bot added the nosec label Feb 15, 2024
@gzukel gzukel changed the title ci: Adjusted docker build pipeline MacOS to install and run Docker, Update docker-compose for full-nodes. ci: Changes to release-pipeline, adding additional automation for setting up nodes locally. Feb 15, 2024
readme.md Outdated Show resolved Hide resolved
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gzukel gzukel merged commit f2adc7d into develop Feb 16, 2024
15 checks passed
@gzukel gzukel deleted the ci-add-docker-build-and-push branch February 16, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Changes to CI pipeline or github actions nosec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants