Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cleanup expected keepers #1754

Merged
merged 10 commits into from
Feb 14, 2024
Merged

chore: cleanup expected keepers #1754

merged 10 commits into from
Feb 14, 2024

Conversation

skosito
Copy link
Contributor

@skosito skosito commented Feb 13, 2024

Description

Cleaned up unused methods from expected keepers interfaces. Also executed make mocks to remove not needed mocks.

One small inconsistency I noticed is that cosmos-sdk modules keepers (for example bank, account keeper etc) are sometimes added as dependency through NewAppModule, and sometimes when module keeper is initialized with NewXKeeper, not sure if there is some particular reason for this, but i tried to clean that up too.

Closes: #1716

Type of change

Cleanup

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

kingpinXD
kingpinXD reviewed Feb 13, 2024
View reviewed changes
app/app.go Outdated Show resolved Hide resolved
kingpinXD
kingpinXD approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@kingpinXD kingpinXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm , left a minor comment

@skosito skosito requested a review from kingpinXD February 13, 2024 23:51
lumtis
lumtis approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! one minor comment

x/fungible/types/expected_keepers.go Outdated Show resolved Hide resolved
kingpinXD
kingpinXD approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@kingpinXD kingpinXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you would need to add a line in the changelog.mg to get the changelog check to pass

@skosito skosito merged commit 0e36d89 into develop Feb 14, 2024
15 checks passed
@skosito skosito deleted the chore-cleanup-expected-keepers branch February 14, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumtis lumtis lumtis approved these changes

@kingpinXD kingpinXD kingpinXD approved these changes

@brewmaster012 brewmaster012 Awaiting requested review from brewmaster012

@kevinssgh kevinssgh Awaiting requested review from kevinssgh

@fadeev fadeev Awaiting requested review from fadeev

@ws4charlie ws4charlie Awaiting requested review from ws4charlie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleaning up x/{module_name}/types/expected_keepers.go
3 participants
@skosito @lumtis @kingpinXD