-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(e2e
): performing clean up and renaming for E2E testing
#1746
Conversation
!!!WARNING!!! Be very careful about using Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203 Pay extra attention to the way |
e2e
): rename smoke test to e2ee2e
): performing clean up and renaming for E2E testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. The tests look very organized
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like a great cleanup, i left couple of comments which are mainly some typos i noticed while reading through readmes, but nothing too important
i also assumed that actual tests code was just moved from one place to another so i didn't review since diff is not detected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked through each change I didn't catch anything. +1
Description
e2e
localnet/orchstrator
is kept specifically for the localnet environment with the docker compose definition, whilee2e
is a package with broader usage, testing live networks for example.localnet
unused scripts, and merge together script with common logicsLOCAL_TESTING.md
to gather all informations regarding local development and testingCloses: #1454 #1618