Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): performing clean up and renaming for E2E testing #1746

Merged
merged 32 commits into from
Feb 21, 2024

Conversation

lumtis
Copy link
Member

@lumtis lumtis commented Feb 9, 2024

Description

  • Rename smoke tests into e2e everywhere for consistency
  • Move the testing packages into a higher level localtion, e2e
    • localnet/orchstrator is kept specifically for the localnet environment with the docker compose definition, while e2e is a package with broader usage, testing live networks for example.
  • Remove in localnet unused scripts, and merge together script with common logics
  • Perform some revamping with the make commands to run e2e, upgrade and stress tests
  • Add a command to run the localnet only without running tests
  • Add a LOCAL_TESTING.md to gather all informations regarding local development and testing

Closes: #1454 #1618

Copy link

github-actions bot commented Feb 9, 2024

!!!WARNING!!!
nosec detected in the following files: e2e/e2etests/test_bitcoin_withdraw.go, e2e/runner/evm.go, cmd/zetae2e/run.go, cmd/zetae2e/stress.go, e2e/config/config.go, e2e/e2etests/e2etests.go, e2e/e2etests/test_update_bytecode.go, e2e/runner/accounting.go, e2e/runner/logger.go

Be very careful about using #nosec in code. It can be a quick way to suppress security warnings and move forward with development, it should be employed with caution. Suppressing warnings with #nosec can hide potentially serious vulnerabilities. Only use #nosec when you're absolutely certain that the security issue is either a false positive or has been mitigated in another way.

Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203
Broad #nosec annotations should be avoided, as they can hide other vulnerabilities. The CI will block you from merging this PR until you remove #nosec annotations that do not target specific rules.

Pay extra attention to the way #nosec is being used in the files listed above.

@github-actions github-actions bot added the nosec label Feb 9, 2024
@github-actions github-actions bot added the ci Changes to CI pipeline or github actions label Feb 9, 2024
@lumtis lumtis marked this pull request as ready for review February 9, 2024 18:24
@lumtis lumtis linked an issue Feb 9, 2024 that may be closed by this pull request
@lumtis lumtis requested a review from skosito as a code owner February 16, 2024 10:56
@lumtis lumtis changed the title test(e2e): rename smoke test to e2e test(e2e): performing clean up and renaming for E2E testing Feb 19, 2024
Copy link
Contributor

@ws4charlie ws4charlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. The tests look very organized

Copy link
Contributor

@skosito skosito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a great cleanup, i left couple of comments which are mainly some typos i noticed while reading through readmes, but nothing too important

i also assumed that actual tests code was just moved from one place to another so i didn't review since diff is not detected

Dockerfile-upgrade Show resolved Hide resolved
LOCAL_TESTING.md Outdated Show resolved Hide resolved
LOCAL_TESTING.md Outdated Show resolved Hide resolved
LOCAL_TESTING.md Outdated Show resolved Hide resolved
LOCAL_TESTING.md Outdated Show resolved Hide resolved
contrib/localnet/README.md Outdated Show resolved Hide resolved
contrib/localnet/README.md Outdated Show resolved Hide resolved
contrib/localnet/orchestrator/Dockerfile Show resolved Hide resolved
contrib/localnet/scripts/start-zetacored.sh Show resolved Hide resolved
@lumtis lumtis requested a review from skosito February 21, 2024 12:29
Copy link
Contributor

@gzukel gzukel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked through each change I didn't catch anything. +1

@lumtis lumtis merged commit 54f364a into develop Feb 21, 2024
15 checks passed
@lumtis lumtis deleted the test/rename-e2e branch February 21, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking:cli ci Changes to CI pipeline or github actions nosec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up the dockerfiles, docker-compose files and scripts in orchestrator Rename smoketest into e2e
5 participants