Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cherry pick hotfix v12.2.5 #1727

Merged
merged 3 commits into from
Feb 8, 2024
Merged

fix: cherry pick hotfix v12.2.5 #1727

merged 3 commits into from
Feb 8, 2024

Conversation

ws4charlie
Copy link
Contributor

Description

Closes: 1721

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

lumtis
lumtis approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, can we please just add requested comment?

zetaclient/bitcoin_client.go Outdated Show resolved Hide resolved
@lumtis lumtis merged commit f65dc1c into develop Feb 8, 2024
15 checks passed
@lumtis lumtis deleted the cherry-pick-hotfix-v12.2.5 branch February 8, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingpinXD kingpinXD kingpinXD approved these changes

@lumtis lumtis lumtis approved these changes

@brewmaster012 brewmaster012 Awaiting requested review from brewmaster012

@kevinssgh kevinssgh Awaiting requested review from kevinssgh

@fadeev fadeev Awaiting requested review from fadeev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zetaclient should provide 'bitcoin_chain_id' when query TSS address
3 participants
@ws4charlie @lumtis @kingpinXD