Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix bitcoin fee rate and increase evm outtx inclusion timeout #1713

Merged
merged 9 commits into from
Feb 8, 2024

Conversation

ws4charlie
Copy link
Contributor

@ws4charlie ws4charlie commented Feb 6, 2024

Description

The economical fee rate sometimes can be half of the conservative fee rate (forgot about taking a screenshot for that. There other day was around 49sats/vB vs. 26 sats/vb).

image

monitored a bit more
image
image

blocks like 829506, 829530, the Fee Span range was quite wide and Conservative gas rate was 3~4 times of
Economical rate.
image
image

Closes: 1707
Closes: 1712

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment on the test

zetaclient/bitcoin_client_test.go Outdated Show resolved Hide resolved
@ws4charlie
Copy link
Contributor Author

ws4charlie commented Feb 8, 2024

LGTM, just one comment on the test

The way I used to run LiveTestSomeTest is to remove the prefix Live of the function (TestBitcoinFeeRate in this case) to make it an executable unit test. It's not an ideal way TBH. If necessary in future, we might need to find a proper way to run tests that require a live mainnet endpoint.

@lumtis lumtis merged commit eb791fb into develop Feb 8, 2024
15 checks passed
@lumtis lumtis deleted the fix-bitcoin-fee-rate branch February 8, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants