Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: json-rpc.allow-unprotected-txs #1691

Merged
merged 3 commits into from
Feb 3, 2024

Conversation

blockpinetwork
Copy link
Contributor

Description

json-rpc.allow-unprotected-txs is not take effect

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Send a Pre-EIP-155 transction and will not get an error of only replay-protected (EIP-155) transactions allowed over RPC

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@brewmaster012
Copy link
Collaborator

good catch! thank you for the contribution.

@lumtis lumtis merged commit 7572fad into zeta-chain:develop Feb 3, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants