Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update default HD path to 60 #1636

Closed
wants to merge 1 commit into from
Closed

docs: update default HD path to 60 #1636

wants to merge 1 commit into from

Conversation

fadeev
Copy link
Member

@fadeev fadeev commented Jan 25, 2024

Changed the HD path in flag description to match what we have in the code.

HDPathEthereum = "m/44'/60'/0'/0/0"

@fadeev fadeev added the no-changelog Skip changelog CI check label Jan 25, 2024
@fadeev
Copy link
Member Author

fadeev commented Jan 25, 2024

Oh, make generate regenerates the docs and replaces 60 with 118 again 🤦‍♂️

@lumtis
Copy link
Member

lumtis commented Jan 26, 2024

Oh, make generate regenerates the docs and replaces 60 with 118 again 🤦‍♂️

I think we might need to overwrite the description of the flag from cosmos-sdk library

@kingpinXD
Copy link
Contributor

Hi @fadeev, do you still want to merge this?

@fadeev
Copy link
Member Author

fadeev commented Mar 26, 2024

Hi @fadeev, do you still want to merge this?

No, as Lucas said, we need to overwrite the default.

@fadeev fadeev closed this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Skip changelog CI check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants