Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cherry-pick ZetaClient fixes from 12.0.4 #1631

Merged
merged 9 commits into from
Jan 25, 2024
Merged

fix: cherry-pick ZetaClient fixes from 12.0.4 #1631

merged 9 commits into from
Jan 25, 2024

Conversation

lumtis
Copy link
Member

@lumtis lumtis commented Jan 24, 2024

Description

Cherry-pick the fixes, except:

lumtis and others added 7 commits January 24, 2024 12:51
@lumtis @ws4charlie
refactor(hotfix): support retrying sending inbound vote with higher…
47c22b7 
… gas limit (#1601)

* chore: v12.0.0 changelog (#1578)

* fix: skip unsupported chain parameters (#1581)

Co-authored-by: Lucas Bertrand <[email protected]>

* remove debug zetaclient1

* remove comments

* tx resend

* complete renaming

* change log level and create constants

* increase retry value

* test change gas limit for outbound

* refactor vote inbound outbound into separate files

* add monitoring capability for outbound txs

* changelog

---------

Co-authored-by: Charlie Chen <[email protected]>
@ws4charlie @lumtis
fix: some necessary code refactor for banned address and bug fix duri…
60f1a5b 
…ng refactor (#1603)
@ws4charlie @lumtis
cherry picked: fixed ChainParams equality check and added changelog e…
aa4ea26 
…ntry
@brewmaster012 @lumtis
respect isSupported in zetaclient observation
d331df1
@brewmaster012 @lumtis
add some RPC diagnosis log
e527979
@brewmaster012 @lumtis
guard against multiple deposits
2beb24b
@brewmaster012 @lumtis
make cosmos go sec linter happy
f1de3de
@github-actions GitHub Actions
Copy link

!!!WARNING!!!
nosec detected in the following files: zetaclient/bitcoin_client.go, zetaclient/broadcast.go, zetaclient/evm_client.go

Be very careful about using #nosec in code. It can be a quick way to suppress security warnings and move forward with development, it should be employed with caution. Suppressing warnings with #nosec can hide potentially serious vulnerabilities. Only use #nosec when you're absolutely certain that the security issue is either a false positive or has been mitigated in another way.

Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203
Broad #nosec annotations should be avoided, as they can hide other vulnerabilities. The CI will block you from merging this PR until you remove #nosec annotations that do not target specific rules.

Pay extra attention to the way #nosec is being used in the files listed above.

@github-actions github-actions bot added the nosec label Jan 24, 2024
@lumtis lumtis requested a review from ws4charlie January 25, 2024 04:50
@lumtis lumtis merged commit d940b94 into develop Jan 25, 2024
15 checks passed
@lumtis lumtis deleted the fix/hotfix-12.0.4 branch January 25, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ws4charlie ws4charlie ws4charlie approved these changes

@kingpinXD kingpinXD kingpinXD approved these changes

@brewmaster012 brewmaster012 Awaiting requested review from brewmaster012

@kevinssgh kevinssgh Awaiting requested review from kevinssgh

@fadeev fadeev Awaiting requested review from fadeev

Assignees
No one assigned
Labels
breaking:cli nosec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lumtis @kingpinXD @ws4charlie @brewmaster012