Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: skip keygen loop #1625

Merged
merged 2 commits into from
Jan 24, 2024
Merged

fix: skip keygen loop #1625

merged 2 commits into from
Jan 24, 2024

Conversation

kingpinXD
Copy link
Contributor

Description

  • Allow zeta-client to start if keygen status is set to PendingKeygen and keygen block is MaxInt64

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

lumtis
lumtis approved these changes Jan 24, 2024
View reviewed changes
cmd/zetaclientd/start.go
}
break
}
// Temporarily allow zeta-client to proceed even if the keygen is set to pending
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it going to be put back for v12.1.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@kingpinXD kingpinXD changed the title fix : skip keygen loop fix: skip keygen loop Jan 24, 2024
@kingpinXD kingpinXD merged commit 74f6a91 into v12.1.0-hotfix Jan 24, 2024
11 checks passed
@kingpinXD kingpinXD deleted the v12.0.4-hotfix-skip-keygen branch January 24, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brewmaster012 brewmaster012 brewmaster012 approved these changes

@lumtis lumtis lumtis approved these changes

@kevinssgh kevinssgh Awaiting requested review from kevinssgh

@fadeev fadeev Awaiting requested review from fadeev

@ws4charlie ws4charlie Awaiting requested review from ws4charlie ws4charlie is a code owner

Assignees
No one assigned
Labels
breaking:cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kingpinXD @lumtis @brewmaster012